Create conversation object #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunthercox
changed the title
| from fuzzywuzzy import process | ||
| import os | ||
| import csv | ||
| from conversation import Conversation |
There was a problem hiding this comment.
This should be either chatterbox.conversation or .conversation in order for it to work in Python 3.
| self.TIMESTAMP = self.timestamp() | ||
| fmt = "%Y-%m-%d-%H-%M-%S" | ||
|
|
||
| self.TIMESTAMP = str(datetime.datetime.now().strftime(fmt)) |
There was a problem hiding this comment.
Shouldn't strftime return a string?
| text = re.sub(r'http[s]?://(?:[a-zA-Z]|[0-9]|[$-_@.&+]|[!*\(\),]|(?:%[0-9a-fA-F][0-9a-fA-F]))+', '', text) | ||
| try: | ||
| text = unicode(text) | ||
| except ImportError: |
There was a problem hiding this comment.
A NameError is actually thrown here, as Python can't find anything named unicode.
There was a problem hiding this comment.
Yeah, I actually have that change made locally. Haven't pushed up the change yet though.
gunthercox
force-pushed
the
conversation
branch
from
b33c680
to
f35b4ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal for this pull request is to create an object that can be used to make managing conversations easier and more efficient.
I've also...