The parser just recognizes case sensitive strings #1291
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gunthercox I tested the parser with some test cases to get datetime objects and I realised that upper letters are crashing the parser when it try to compare strings.
In the first scenario below, as the parser uses the function date_from_relative_week_year, the function argument time assigned with string "Next" is not equals to string "next" and the function will return a "NoneType".
Scenario 1:
In the second scenario, the parser uses the function convert_time_to_hour_minute. As similar before, the function will return a "NoneType" because the comparison between the convention argument (storing the string "PM") and string "pm" is false.
Scenario 2: