Add filters step to response selection process #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@navyad That is correct. |
gunthercox
force-pushed
the
filters
branch
3 times, most recently
from
1ca1de9
to
ba7d4b7
Compare
This makes it possible to create a base query that will filter out certain results from each query that is made.
This cannot currently be restricted to the base query without sometimes triggering an Exception because the base query can eliminate all possible response options.
There are some addition complex issues that need to be resolved before this filter can be created. I will add it in it's own pull request to keep rest of the filters pull request moving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filters are a new concept that make it more efficient to reduce the number of responses being processed. The filter methods are called before the logic adapter retrieves a set of possible response statements from the database. The significance is that filters operate using set logic so they will be faster than iterative logic that has to be used in many of the logic adapters. The goal of the filters is to filter out any statements that can't possible be valid responses before the results are passed to the logic adapters.