Integration with Microsoft Bot Framework #381

vkosuri · 2016-11-04T17:39:44Z

Closes #290

vkosuri · 2016-11-04T17:41:11Z

chatterbot/adapters/output/microsoft.py

+class Microsoft(OutputAdapter):
+    """
+    An output adapter that allows a ChatterBot instance to send
+    responses to a HipChat room.


Copy paste error

gunthercox · 2016-11-05T13:10:13Z

@vkosuri Looks good, is this ready to be reviewed?

vkosuri · 2016-11-05T13:12:18Z

Thanks , I am working on documentation part also, i will push some more
comits. by today.

On 05-Nov-2016 6:40 PM, "Gunther Cox" [email protected] wrote:

@vkosuri https://github.com/vkosuri Looks good, is this ready to be
merged?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#381 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANCAAV2HF-k74IE5x4xmWKfjLYZ59ESaks5q7IA5gaJpZM4KpznB
.

vkosuri · 2016-11-05T17:46:44Z

@gunthercox i haven't added tests for this PR, i will add soon, do you have any comments/suggestions on this PR?

gunthercox · 2016-11-05T23:32:08Z

@vkosuri From what I can see, this looks fantastic.

In the examples, is the value for directline_access_token_or_secret an actual access token?

vkosuri · 2016-11-06T00:28:30Z

Yes, https://docs.botframework.com/en-us/restapi/directline/

vkosuri · 2016-11-07T13:18:18Z

@gunthercox any comments/suggestions?

gunthercox · 2016-11-08T00:35:27Z

Comments & feedback

Overall, the code looks fantastic.
I'm very glad to see that logging statements were included.
It might be useful to include a simple example program in the examples directory. This would also be helpful for manual testing since there aren't any unit tests yet.

I would be happy to help write tests for this, let me know.

vkosuri · 2016-11-09T03:42:03Z

vkosuri · 2016-11-11T07:01:30Z

@gunthercox any comments/suggestions?

gunthercox · 2016-11-12T13:54:01Z

How did you get the value to use for the conversation_id? I'm trying to set up the example to run locally, do I need to manually authenticate with the API and start a new conversation to get a conversation_id?

vkosuri · 2016-11-12T16:08:50Z

You eill get it from here

Request URL
https://directline.botframework.com/api/conversations
Response Body
{
  "conversationId": "ENwpIpwOny6",
  "token": "xtFDtPemROU.dAA.RQBOAHcAcABJAHAAdwBPAG4AeQA2AA.IEz11QI90gE.XXui3MZv4-8.kg2KPXCgTU8mcEE_DB07mUQHKG_C-t6c-ISlI0UDM0Q",
  "expires_in": 0
}

gunthercox

I've left comments on a few lines where some very minor changes/improvements could be made.

gunthercox · 2016-11-12T21:30:54Z

chatterbot/adapters/input/microsoft.py

+    def __init__(self, **kwargs):
+        super(Microsoft, self).__init__(**kwargs)
+
+        self.directline_host = kwargs.get('directline_host')


It might be a good idea to add a default value here so that directline_host does not always need to be specified. I'm fairly certain that the direct line host endpoint will usually be the same for every developer.

kwargs.get('directline_host', 'https://directline.botframework.com')

gunthercox · 2016-11-12T21:31:53Z

chatterbot/adapters/output/microsoft.py

+    def __init__(self, **kwargs):
+        super(Microsoft, self).__init__(**kwargs)
+
+        self.directline_host = kwargs.get("directline_host")


This get method should also have the default set.

kwargs.get('directline_host', 'https://directline.botframework.com')

gunthercox · 2016-11-12T21:34:10Z

docs/adapters/input.rst

+       input_adapter="chatterbot.adapters.input.Microsoft",
+       directline_host="https://directline.botframework.com",
+       dirctline_conversation_id="IEyJvnDULgn",
+       directline_access_token_or_secret="RCurR_XV9ZA.cwA.BKA.iaJrC8xpy8qbOF5xnR2vtCX7CZj0LdjAPGfiCpg4Fv0",


It looks like the directline_access_token_or_secret parameter was changed to direct_line_token_or_secret in the code.

gunthercox · 2016-11-12T21:35:33Z

docs/adapters/output.rst

+       output_adapter="chatterbot.adapters.output.Microsoft",
+       direct_line_host="https://directline.botframework.com",
+       direct_line_conservationId="IEyJvnDULgn",
+       direct_line_access_token_or_secret="RCurR_XV9ZA.cwA.BKA.iaJrC8xpy8qbOF5xnR2vtCX7CZj0LdjAPGfiCpg4Fv0",


I believe in this example, direct_line_access_token_or_secret should also be changed to direct_line_token_or_secret.

gunthercox · 2016-11-13T23:07:18Z

I believe all the changes here look good.

Mallikarjunarao Kosuri added 2 commits November 4, 2016 22:46

microsoft input adapter

ecac471

microsoft output adapter

f69d221

vkosuri commented Nov 4, 2016

View reviewed changes

Mallikarjunarao Kosuri added 4 commits November 5, 2016 22:14

name changes

980d537

pep8

cee691d

doc updation

2fa1924

small correction

34939ae

gunthercox approved these changes Nov 5, 2016

View reviewed changes

Mallikarjunarao Kosuri added 4 commits November 11, 2016 09:08

example code

ff41ce7

removed unused statement

5eb4766

input adapter updation

c61e902

output adapter updation

1b33b04

gunthercox requested changes Nov 13, 2016

View reviewed changes

comments incorporated

c38842f

gunthercox approved these changes Nov 13, 2016

View reviewed changes

gunthercox merged commit e99cff5 into gunthercox:master Nov 13, 2016

vkosuri deleted the issue-290 branch August 15, 2017 03:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integration with Microsoft Bot Framework #381

Integration with Microsoft Bot Framework #381

vkosuri commented Nov 4, 2016 •

edited by gunthercox

Loading

vkosuri Nov 4, 2016

gunthercox commented Nov 5, 2016 •

edited

Loading

vkosuri commented Nov 5, 2016

vkosuri commented Nov 5, 2016

gunthercox commented Nov 5, 2016

vkosuri commented Nov 6, 2016 via email

vkosuri commented Nov 7, 2016

gunthercox commented Nov 8, 2016

vkosuri commented Nov 9, 2016 •

edited

Loading

vkosuri commented Nov 11, 2016

gunthercox commented Nov 12, 2016

vkosuri commented Nov 12, 2016

gunthercox left a comment

gunthercox Nov 12, 2016

gunthercox Nov 12, 2016

gunthercox Nov 12, 2016

gunthercox Nov 12, 2016

gunthercox commented Nov 13, 2016

Integration with Microsoft Bot Framework #381

Integration with Microsoft Bot Framework #381

Conversation

vkosuri commented Nov 4, 2016 • edited by gunthercox Loading

vkosuri Nov 4, 2016

Choose a reason for hiding this comment

gunthercox commented Nov 5, 2016 • edited Loading

vkosuri commented Nov 5, 2016

vkosuri commented Nov 5, 2016

gunthercox commented Nov 5, 2016

vkosuri commented Nov 6, 2016 via email

vkosuri commented Nov 7, 2016

gunthercox commented Nov 8, 2016

vkosuri commented Nov 9, 2016 • edited Loading

vkosuri commented Nov 11, 2016

gunthercox commented Nov 12, 2016

vkosuri commented Nov 12, 2016

gunthercox left a comment

Choose a reason for hiding this comment

gunthercox Nov 12, 2016

Choose a reason for hiding this comment

gunthercox Nov 12, 2016

Choose a reason for hiding this comment

gunthercox Nov 12, 2016

Choose a reason for hiding this comment

gunthercox Nov 12, 2016

Choose a reason for hiding this comment

gunthercox commented Nov 13, 2016

vkosuri commented Nov 4, 2016 •

edited by gunthercox

Loading

gunthercox commented Nov 5, 2016 •

edited

Loading

vkosuri commented Nov 9, 2016 •

edited

Loading