Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add session management #424

Merged
merged 11 commits into from
Nov 28, 2016
Merged

Add session management #424

merged 11 commits into from
Nov 28, 2016

Conversation

gunthercox
Copy link
Owner

@gunthercox gunthercox commented Nov 27, 2016

  • Create new session objects
  • Allow integration with Django sessions
  • Add tests for sessions
  • Update documentation

Closes #372

@gunthercox gunthercox merged commit ed10494 into master Nov 28, 2016
@gunthercox gunthercox deleted the sessions branch November 28, 2016 01:43
@vkosuri
Copy link
Collaborator

vkosuri commented Nov 28, 2016

@gunthercox will it consider other bot session objects, for example gitter/microsoft session object was expired then chatterbot session object will expire?, will this case is considered?

@gunthercox
Copy link
Owner Author

If two bots are created, each will have sessions separate from each other.

bot1 = ChatBot()
bot2 = ChatBot()

For each bot, the sessions could be shared across multiple adapters as long as there is a shared session id. Right now this is something that the developer would have to handle manually because a ChatBot instance has no way of knowing that a Gitter user is the same person as a user on the Microsoft Bot Framework. To handle this, the developer would likely have to store associations between a unique identifier and a user's verified usernames for each service (Gitter, HipChat, Microsoft Bot Framework, etc.).

Hopefully this answers your question. I'm planning to add more documentation on this to hopefully make it clearer.

@vkosuri
Copy link
Collaborator

vkosuri commented Nov 28, 2016

Nice, Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants