Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

response into JSON object #498

Merged
merged 6 commits into from
Dec 15, 2016
Merged

response into JSON object #498

merged 6 commits into from
Dec 15, 2016

Conversation

vkosuri
Copy link
Collaborator

@vkosuri vkosuri commented Dec 12, 2016

Somehow the current djanog response isn't converting into JSON object, it always returns. #497 issue will fix this error.

Copy link
Owner

@gunthercox gunthercox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is going to need tests to be added. At minimum, the tests should confirm:

  1. The response statements are correctly converted to JSON objects
  2. The issue is fixed for unicode strings

@vkosuri
Copy link
Collaborator Author

vkosuri commented Dec 12, 2016

@gunthercox sure will work on those two tests, One question, where do i need to add these test either in django example app tests or in django_tests

@gunthercox
Copy link
Owner

gunthercox commented Dec 12, 2016

These tests should be in the tests_django directory. You can run these django-specific tests with:

python runtests.py

@vkosuri
Copy link
Collaborator Author

vkosuri commented Dec 13, 2016

@gunthercox i am little busy with other tasks, It may take another day or two, Could you please let me are there any ETAs for new release?

@gunthercox
Copy link
Owner

I don't have an ETA yet, I'm possibly looking to do one either this weekend or next week.

@vkosuri
Copy link
Collaborator Author

vkosuri commented Dec 15, 2016

appologies for many failures, needs to learn python3 📦

@gunthercox
Copy link
Owner

This looks great, thank you for adding the test cases. They help make sure that this functionality never breaks again in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants