-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
response into JSON object #498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is going to need tests to be added. At minimum, the tests should confirm:
- The response statements are correctly converted to JSON objects
- The issue is fixed for unicode strings
@gunthercox sure will work on those two tests, One question, where do i need to add these test either in django example app tests or in django_tests |
These tests should be in the
|
@gunthercox i am little busy with other tasks, It may take another day or two, Could you please let me are there any ETAs for new release? |
I don't have an ETA yet, I'm possibly looking to do one either this weekend or next week. |
appologies for many failures, needs to learn |
This looks great, thank you for adding the test cases. They help make sure that this functionality never breaks again in the future. |
Somehow the current djanog response isn't converting into JSON object, it always returns. #497 issue will fix this error.