Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specification of ssl verification for hipchat adapters. #875

Merged
merged 1 commit into from
Jul 30, 2017
Merged

Allow specification of ssl verification for hipchat adapters. #875

merged 1 commit into from
Jul 30, 2017

Conversation

Achimh3011
Copy link
Contributor

Allow specification of ssl verification for hipchat adapters by adding an optional config variable to the chatbot instance.

@vkosuri
Copy link
Collaborator

vkosuri commented Jul 26, 2017

Some information about input and output adapters #528

The tests are failing due to pep8 issue

4.20s$ flake8
./chatterbot/output/hipchat.py:32:5: E303 too many blank lines (3)

@Achimh3011
Copy link
Contributor Author

Achimh3011 commented Jul 28, 2017 •
edited
Loading

Fixed flake8.

Blinking test tests/storage_adapter_tests/test_sqlalchemy_adapter.pyis also unstable on master.

I saw that removal of I/O adapters is still "future", so it might not hurt to merge this small feature.

@gunthercox
Copy link
Owner

@Achimh3011 Thank you.

@gunthercox gunthercox merged commit 04b064e into gunthercox:master Jul 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkosuri vkosuri vkosuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Achimh3011 @vkosuri @gunthercox