Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cfg-expr to support parsing of target_abi cfg #33

Closed
wants to merge 2 commits into from

Conversation

carols10cents
Copy link
Contributor

@carols10cents carols10cents commented Nov 7, 2022

Hi!!

Over at IOx, we tried to upgrade to ahash 0.8.1. ahash v0.8.1 uses target_abi in some of its cfgs.

target_abi is currently unstable, but is described in:

cargo hakari couldn't parse target_abi and fails with this error:

Error: 
   0: building package graph failed
   1: failed to construct package graph: for package 'ahash 0.8.1 (registry+https://github.com/rust-lang/crates.io-index)': for dependency 'getrandom', parsing target 'cfg(any(target_arch = "wasm32", target_abi = "unknown"))' failed: invalid cfg() expression

I sent a PR to cfg-expr and it got merged and released as cfg-expr 0.12.0.

This PR upgrades target-spec to that version and adds a regression test that TargetSpec will parse target_abi correctly.

Thank you!!!

@sunshowers
Copy link
Member

Thanks, looking at this now.

@sunshowers
Copy link
Member

@carols10cents this is now out as cargo-hakari 0.9.16.

@carols10cents
Copy link
Contributor Author

@sunshowers Thank you so much, it works!!! https://github.com/influxdata/influxdb_iox/pull/6032

@carols10cents carols10cents deleted the support-target-abi branch November 9, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants