forked from elastic/elasticsearch
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ProfileScorer should propagate
setMinCompetitiveScore. (elastic#40958)
Currently enabling profiling disables top-hits optimizations, which is unfortunate: it would be nice to be able to notice the difference in method counts and timings depending on whether total hit counts are requested.
- Loading branch information
Showing
4 changed files
with
125 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92 changes: 92 additions & 0 deletions
92
server/src/test/java/org/elasticsearch/search/profile/query/ProfileScorerTests.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| /* | ||
| * Licensed to Elasticsearch under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.elasticsearch.search.profile.query; | ||
|
|
||
| import org.apache.lucene.index.MultiReader; | ||
| import org.apache.lucene.search.DocIdSetIterator; | ||
| import org.apache.lucene.search.IndexSearcher; | ||
| import org.apache.lucene.search.MatchAllDocsQuery; | ||
| import org.apache.lucene.search.Query; | ||
| import org.apache.lucene.search.ScoreMode; | ||
| import org.apache.lucene.search.Scorer; | ||
| import org.apache.lucene.search.Weight; | ||
| import org.elasticsearch.test.ESTestCase; | ||
|
|
||
| import java.io.IOException; | ||
|
|
||
| public class ProfileScorerTests extends ESTestCase { | ||
|
|
||
| private static class FakeScorer extends Scorer { | ||
|
|
||
| public float maxScore, minCompetitiveScore; | ||
|
|
||
| protected FakeScorer(Weight weight) { | ||
| super(weight); | ||
| } | ||
|
|
||
| @Override | ||
| public DocIdSetIterator iterator() { | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| @Override | ||
| public float getMaxScore(int upTo) throws IOException { | ||
| return maxScore; | ||
| } | ||
|
|
||
| @Override | ||
| public float score() throws IOException { | ||
| return 1f; | ||
| } | ||
|
|
||
| @Override | ||
| public int docID() { | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| @Override | ||
| public void setMinCompetitiveScore(float minScore) { | ||
| this.minCompetitiveScore = minScore; | ||
| } | ||
| } | ||
|
|
||
| public void testPropagateMinCompetitiveScore() throws IOException { | ||
| Query query = new MatchAllDocsQuery(); | ||
| Weight weight = query.createWeight(new IndexSearcher(new MultiReader()), ScoreMode.TOP_SCORES, 1f); | ||
| FakeScorer fakeScorer = new FakeScorer(weight); | ||
| QueryProfileBreakdown profile = new QueryProfileBreakdown(); | ||
| ProfileWeight profileWeight = new ProfileWeight(query, weight, profile); | ||
| ProfileScorer profileScorer = new ProfileScorer(profileWeight, fakeScorer, profile); | ||
| profileScorer.setMinCompetitiveScore(0.42f); | ||
| assertEquals(0.42f, fakeScorer.minCompetitiveScore, 0f); | ||
| } | ||
|
|
||
| public void testPropagateMaxScore() throws IOException { | ||
| Query query = new MatchAllDocsQuery(); | ||
| Weight weight = query.createWeight(new IndexSearcher(new MultiReader()), ScoreMode.TOP_SCORES, 1f); | ||
| FakeScorer fakeScorer = new FakeScorer(weight); | ||
| QueryProfileBreakdown profile = new QueryProfileBreakdown(); | ||
| ProfileWeight profileWeight = new ProfileWeight(query, weight, profile); | ||
| ProfileScorer profileScorer = new ProfileScorer(profileWeight, fakeScorer, profile); | ||
| profileScorer.setMinCompetitiveScore(0.42f); | ||
| fakeScorer.maxScore = 42f; | ||
| assertEquals(42f, profileScorer.getMaxScore(DocIdSetIterator.NO_MORE_DOCS), 0f); | ||
| } | ||
| } |