Fixes ConstructorInjector rented array return

gustavopsantos · Jan 4, 2023 · d51853c · d51853c
1 parent de8c737
commit d51853c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/Assets/Reflex/Scripts/Injectors/ConstructorInjector.cs b/Assets/Reflex/Scripts/Injectors/ConstructorInjector.cs
@@ -1,5 +1,4 @@
 using System;
-using Reflex.Scripts;
 
 namespace Reflex.Injectors
 {
@@ -18,13 +17,16 @@ internal static object ConstructAndInject(Type concrete, Container container)
 
 			try
 			{
-				var instance = info.Activator(objects);
-				ArrayPool<object>.Shared.Return(objects);
-				return instance;
+				return info.Activator(objects);
 			}
 			catch (Exception e)
 			{
-				throw new Exception($"Error occurred while instantiating object with type '{concrete.GetFormattedName()}'\n\n{e.Message}");
+				throw new Exception(
+					$"Error occurred while instantiating object with type '{concrete.GetFormattedName()}'\n\n{e.Message}");
+			}
+			finally
+			{
+				ArrayPool<object>.Shared.Return(objects);
 			}
 		}
 

diff --git a/Assets/Reflex/package.json b/Assets/Reflex/package.json
@@ -1,7 +1,7 @@
 {
   "name": "com.gustavopsantos.reflex",
   "displayName": "Reflex",
-  "version": "3.5.1",
+  "version": "3.5.2",
   "unity": "2019.3",
   "description": "Minimal dependency injection framework for Unity",
   "keywords": ["Dependency Injection", "IoC", "DI", "DI Container"],

diff --git a/README.md b/README.md
@@ -78,7 +78,7 @@ Reflex is an [Dependency Injection](https://stackify.com/dependency-injection/)
 
 ### Install via UPM (using Git URL)
 ```json
-"com.gustavopsantos.reflex": "https://github.com/gustavopsantos/reflex.git?path=/Assets/Reflex/#3.5.1"
+"com.gustavopsantos.reflex": "https://github.com/gustavopsantos/reflex.git?path=/Assets/Reflex/#3.5.2"
 ```
 
 ### Install manually (using .unitypackage)