Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance Mac keymap #7

Merged
merged 3 commits into from
Sep 29, 2016
Merged

enhance Mac keymap #7

merged 3 commits into from
Sep 29, 2016

Conversation

wicksome
Copy link
Contributor

@wicksome wicksome commented Sep 3, 2016

No description provided.

guylabs
guylabs requested changes Sep 24, 2016
View reviewed changes
Copy link
Owner

@guylabs guylabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @5pid

thanks a lot for the PR! Really appreciate such contributions. I just added some review comments. Could you maybe go through them and adapt these such that I can merge it with the master and release a new version?

If you have any questions please ask.

Thanks and regards,

Guy

keymaps/intellij-idea-keymap.cson
##########

# Select Next Tab
'cmd-shift-]': 'pane:show-next-item'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shortcut already works out of the box in Atom. I would remove it here such that we just have the shortcuts which are different between IDEA and Atom.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted line.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is still in and is not deleted. Could you also delete this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. It is my mistake.

keymaps/intellij-idea-keymap.cson
'cmd-shift-]': 'pane:show-next-item'

# Select Previous Tab
'cmd-shift-[': 'pane:show-previous-item'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shortcut already works out of the box in Atom. I would remove it here such that we just have the shortcuts which are different between IDEA and Atom.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is still in and is not deleted. Could you also delete this one?

keymaps/intellij-idea-keymap.cson
# General #
###########

'left': 'tree-view:collapse-directory'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shortcut already works out of the box in Atom. I would remove it here such that we just have the shortcuts which are different between IDEA and Atom.

This is also the case for right and enter.

keymaps/intellij-idea-keymap.cson
# Editing #
###########

'cmd-c': 'tree-view:copy'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shortcut already works out of the box in Atom. I would remove it here such that we just have the shortcuts which are different between IDEA and Atom.

This is also the case for:

  • cmd-x
  • cmd-v
  • backspace

The delete I cannot test as I only have the laptop keyboard. ;)

@wicksome
Copy link
Contributor Author

wicksome commented Sep 25, 2016 •
edited
Loading

@guylabs
Thanks for reviews.
I fixed some shortcuts that you refered to me.
Please check commit.

guylabs
guylabs requested changes Sep 25, 2016
View reviewed changes
Copy link
Owner

@guylabs guylabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @5pid

thanks for the quick changes but there are still some lines which need to be removed and please also remove all the unset! shortcuts as we do not want to remove the standard Atom shortcuts.

After these changes I can merge it and release a newer version.

Thanks and regards,

Guy

keymaps/intellij-idea-keymap.cson
##########

# Select Next Tab
'cmd-shift-]': 'pane:show-next-item'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is still in and is not deleted. Could you also delete this one?

keymaps/intellij-idea-keymap.cson
'cmd-shift-]': 'pane:show-next-item'

# Select Previous Tab
'cmd-shift-[': 'pane:show-previous-item'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is still in and is not deleted. Could you also delete this one?

keymaps/intellij-idea-keymap.cson
@@ -109,17 +136,55 @@

# Go to line
'cmd-l': 'go-to-line:toggle'
'cmd-\\': 'unset!' # cancel the tree-view shortcut
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not unset the standard shortcuts as the shortcuts for idea should just be an addition to the default ones. Could you maybe remove all the unset! shortcuts?

keymaps/intellij-idea-keymap.cson
# Editing #
###########

'ctrl-shift-C': 'unset!'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not unset the standard shortcuts as the shortcuts for idea should just be an addition to the default ones. Could you maybe remove all the unset! shortcuts?

keymaps/intellij-idea-keymap.cson

'ctrl-shift-C': 'unset!'
'cmd-shift-c': 'tree-view:copy-full-path'
'f2': 'unset!'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not unset the standard shortcuts as the shortcuts for idea should just be an addition to the default ones. Could you maybe remove all the unset! shortcuts?

keymaps/intellij-idea-keymap.cson
@@ -109,17 +136,55 @@

# Go to line
'cmd-l': 'go-to-line:toggle'
'cmd-\\': 'unset!' # cancel the tree-view shortcut
'cmd-k cmd-b': 'unset!' # cancel the tree-view shortcut
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not unset the standard shortcuts as the shortcuts for idea should just be an addition to the default ones. Could you maybe remove all the unset! shortcuts?

keymaps/intellij-idea-keymap.cson
# General #
###########

'a': 'unset!'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not unset the standard shortcuts as the shortcuts for idea should just be an addition to the default ones. Could you maybe remove all the unset! shortcuts?

@guylabs guylabs added this to the 0.2.2 milestone Sep 25, 2016
@guylabs guylabs self-assigned this Sep 25, 2016
@wicksome
Copy link
Contributor Author

@guylabs
Sorry. my mistake.
I deleted that missing codes.
Thanks for reviews.

@guylabs guylabs changed the title add Mac keymap enhance Mac keymap Sep 29, 2016
@guylabs guylabs merged commit f8432bc into guylabs:master Sep 29, 2016
@guylabs guylabs mentioned this pull request Sep 29, 2016
Closed
guylabs pushed a commit that referenced this pull request Oct 1, 2016
Add contribution author for PR #7
8a1b2d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guylabs guylabs guylabs approved these changes

Assignees

@guylabs guylabs

Labels
enhancement
Projects
None yet
Milestone
0.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@wicksome @guylabs