MockHandler - Add support to reset internal queue #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sagikazarmark @Nyholm Please let me know what do you think about this little feature, and whether this is the correct way of doing this or if there is a better way that maybe I'm not aware of. |
ingluisjimenez
force-pushed
the
mock-handler-reset-queue
branch
2 times, most recently
from
9e2dde8
to
0ff5bf2
Compare
ingluisjimenez
force-pushed
the
mock-handler-reset-queue
branch
from
0ff5bf2
to
b67d0ad
Compare
|
rebased with latest from master |
sagikazarmark
approved these changes
Oct 23, 2019
|
Thank you for reviewing/merging! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actual Behavior
MockHandler doesn't offer a way of resetting the internal queue. There are testing scenarios where the handler has been initialized in the setUp() method of a test suite, to avoid duplication, and some specific responses are queued up as the default behavior but then you have tests which need to queue up something different (i.e a request error).
In this cases, it is not possible to reuse the handler defined in setUp(), and instad, it is required to re-instantiate and re-wire a handler and the dependencies all over again.
Expected Behavior
To avoid having to wire and set up the handler all over again, it would be great to expose a way to reset the internal queue in the MockHandler instance, and then just queue the new response(s).
This PR adds a method to MockHandler to reset the internal queue. Calling
$handler->reset();would reset the internal array and allow the tester to queue up new responses.