Rename the likelihood module to models

[cdcapano]

This renames the likelihood module to models. Also renames all instances of likelihood_evaluator to model in the sampler module and elsewhere. The BaseLikelihoodEvaluator has been renamed Model and DataBasedLikelihoodEvaluator has been renamed DataModel.

Depends on #33.

[pep8speaks]

Hello @cdcapano! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on July 12, 2018 at 08:28 Hours UTC

[coveralls]

Pull Request Test Coverage Report for Build 134

• 103 of 191 (53.93%) changed or added relevant lines in 12 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.04%) to 39.437%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
gwin/workflow.py	0	1	0.0%
gwin/models/init.py	4	5	80.0%
gwin/sampler/mcmc.py	7	8	87.5%
gwin/sampler/kombine.py	10	13	76.92%
gwin/io/hdf.py	5	12	41.67%
gwin/sampler/emcee.py	19	29	65.52%
gwin/option_utils.py	5	16	31.25%
gwin/models/analytic.py	9	21	42.86%
gwin/sampler/base.py	11	27	40.74%
gwin/models/base.py	23	49	46.94%

Totals
Change from base Build 130:	-0.04%
Covered Lines:	1008
Relevant Lines:	2556

---

💛 - Coveralls

[duncanmmacleod]

LGTM

[cdcapano]

Also renamed sampling_parameters --> sampling_params, variable_args --> variable_params; static_args --> static_params to make terminology consistent.

This depends on the next pycbc release, so putting on hold until that's out (should be today or tomorrow).

[cdcapano]

Actually, looks like I can merge this now without failing Travis. This will break gwin if you don't have current pycbc master installed, but the new release should come out in the next few days. Would be good to merge this now, to simplify #36.

[vivienr]

Should we have codeclimate setting's relaxed a little?

[vivienr]

LGTM