Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Jupyter Notebooks #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

WIP: Jupyter Notebooks #21

wants to merge 3 commits into from

Conversation

sarahmorin
Copy link
Contributor

This branch is not done, but feedback would be helpful!

Notebooks

  • Instructions for local set up
  • Basic R2B2 Usage
    • Draft done, needs refinement
  • Generating a graph using a bulk method
  • Comparison of audits using interactive run() method.
    • Draft done, needs refinement

Ideas

  • Notebooks to explain each audit

initial notebooks to explain R2B2 usage:
- WELCOME: explains how to set up personal environment to use notebooks
locally
- R2B2 Basics: walk through of basic uses
- Generating Graphs: Shows how to use compute_all_min_winner_ballots to
make a graph comparing stopping sizes for different risk limits.
- Interactive Audit: Demo of the run() method with suggested input.
@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #21 into master will increase coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   82.62%   83.16%   +0.53%     
==========================================
  Files          13       14       +1     
  Lines         685      879     +194     
  Branches       92      160      +68     
==========================================
+ Hits          566      731     +165     
- Misses        108      132      +24     
- Partials       11       16       +5     
Impacted Files Coverage Δ
src/r2b2/tests/util.py 28.30% <0.00%> (-1.49%) ⬇️
src/r2b2/audit.py 65.78% <0.00%> (-0.53%) ⬇️
src/r2b2/tests/test_audit.py 98.66% <0.00%> (-0.51%) ⬇️
src/r2b2/cli.py 100.00% <0.00%> (ø)
src/r2b2/contest.py 100.00% <0.00%> (ø)
src/r2b2/tests/test_contest.py 100.00% <0.00%> (ø)
tests/test_brla.py 100.00% <0.00%> (ø)
src/r2b2/brla.py 90.27% <0.00%> (+9.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9353945...aec0216. Read the comment docs.

@nealmcb
Copy link
Contributor

nealmcb commented Apr 29, 2020

I haven't tried all the different approaches here, but my guess is that the advice for interim use and development should be to use
pip install --editable ./ vs
python setup.py build install and the like, as discussed at
https://stackoverflow.com/questions/30306099/pip-install-editable-vs-python-setup-py-develop
and in the security warning at https://pip.pypa.io/en/stable/reference/pip_install/

@sarahmorin
Copy link
Contributor Author

I haven't tried all the different approaches here, but my guess is that the advice for interim use and development should be to use
pip install --editable ./ vs
python setup.py build install and the like, as discussed at
https://stackoverflow.com/questions/30306099/pip-install-editable-vs-python-setup-py-develop
and in the security warning at https://pip.pypa.io/en/stable/reference/pip_install/

Thanks, good note!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants