Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add joblib to dependencies #277

Closed
OnnoEbbens opened this issue Oct 26, 2023 · 0 comments · Fixed by #279
Closed

add joblib to dependencies #277

OnnoEbbens opened this issue Oct 26, 2023 · 0 comments · Fixed by #279
Labels
caching All caching related issues

Comments

@OnnoEbbens
Copy link
Collaborator

In nlmod 0.7.0 we use joblib and added it as an import to the top of the cache module because Codcay was complaining. So now you get an importerror when you import nlmod and not have joblib installed.

Should be an easy fix.
OnnoEbbens added a commit that referenced this issue Oct 31, 2023
@OnnoEbbens
Fix for #277
8e5d5a2
@OnnoEbbens OnnoEbbens linked a pull request Oct 31, 2023 that will close this issue
Add Joblib to dependencies, Fix for #277 #279
Merged
OnnoEbbens added a commit that referenced this issue Nov 1, 2023
@OnnoEbbens
Add Joblib to dependencies, Fix for #277 (#279)
c6e903f 
* Fix for #277

* Update README.md

* Update getting_started.rst
@OnnoEbbens OnnoEbbens added the caching All caching related issues label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
caching All caching related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Joblib to dependencies, Fix for #277 gwmod/nlmod
2 participants
@dbrakenhoff @OnnoEbbens