Checkstyle import rules should be consistent with the codebase #9920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old checkstyle was similar but not identical to the Google Java Style Guide, and it seems that checkstyle updates have changed import behaviors in a way to make them incompatible with those conventions (but more compatible with the Google style). These new rules are a close approximation to the old convention, with a few exceptions, mostly that imports are all listed at the top. There were also some inconsistencies, such as grouping jsinterop and javaemul with java packages - those have been resolved as simply as possible, with checkstyle rules to enforce this.
|
Added a commit which relied on line numbers in Throwable not changing, so that this test still passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old checkstyle was similar but not identical to the Google Java Style Guide, and it seems that checkstyle updates have changed import behaviors in a way to make them incompatible with those conventions (but more compatible with the Google style). These new rules are a close approximation to the old convention, with a few exceptions, mostly that imports are all listed at the top. There were also some inconsistencies, such as grouping jsinterop and javaemul with java packages - those have been resolved as simply as possible, with checkstyle rules to enforce this.