Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated or internal types, mark unused code deprecated #9925

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

niloc132
Copy link
Contributor

@niloc132 niloc132 commented Feb 13, 2024

Fixes #9923
Fixes #9921

@niloc132 niloc132 added this to the 2.12 milestone May 11, 2024
Copy link
Member

@jnehlmeier jnehlmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe RequestFactoryJarExtractor can be extracted as a dedicated tool in the future so it becomes more visible (e.g. stored in build_tools).

@niloc132
Copy link
Contributor Author

Agreed, though I'm loathe to write more ant build files if we can help it - far rather finish converting to cleaner source directories and then as we need to write packaging code for building gwt-user/dev/servlet artifacts, also make this fit into that mold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GWT 2.12 deprecations/removals Finish removing deprecated SynchronousFragmentLoadCallback
2 participants