Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove first character for delegating args to CodeServer #9940

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

MCMicS
Copy link
Contributor

@MCMicS MCMicS commented Mar 19, 2024

fix for #9939

Copy link
Contributor

@niloc132 niloc132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and I don't see another clear way to achieve this. The code as it stands doesn't appear very testable, so I'm leaning to merge as is, with a round of manual testing of the fix (maybe added to the release test plan too).

@MCMicS
Copy link
Contributor Author

MCMicS commented Mar 20, 2024

I like the solution not so because I check if it starts with a +. Maybe I can remove it always but I not know all possible values at this point. So this is IMO a safe solution

I can try to write a test to check that the generated codeServerArgs are correct after call the constructor. I can do this the days.

Do you think it makes sense to do this?

@niloc132 niloc132 merged commit e43a589 into gwtproject:main Apr 7, 2024
3 checks passed
@niloc132 niloc132 added this to the 2.12 milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants