Added typescript lib interface + Airbnb Eslint addition and fixes #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returned KnexStore construction inside the lib's init function, because it must be dynamically created with the session object provided by user
… refuse all connections without a password Travis should still work without db passwords, should just add ON_TRAVIS=1 in Travis's env
Fixed lint errors in some of example-postgres.js
omarryhan
changed the title
|
Also, I think we should create a |
|
@omarryhan well done. |
|
@omarryhan sorry I didn't seen your MR sooner. notifications can get rather cluttered on github :( |
|
It's alright :) |
|
Hey @llambda , Sorry to bother you again. Turns out there was a bug in this PR. Someone made a PR with a fix here. I merged it, then pushed a couple of other code organization chores and we're ready for a new release. Just thought I'd notify you with a ping, in case the notification didn't reach you. |
|
Many thanks !! |
gx0r
pushed a commit
that referenced
this pull request
Jan 15, 2021
* Added TS support * Added eslint * added knex to prod dependencies instead of dev * Removed unnecessary function input * Fixed lint errors * Fixed error where a bitwise operator was used instead of standard or * Fixed lint errors in test.js Returned KnexStore construction inside the lib's init function, because it must be dynamically created with the session object provided by user * Added testing instructions to README * Removed node v8 from Travis.yml * Fixed an ignored minor lint error: Favor global import * Fixed lint errors in example.js * Running tests locally with passwords, because both MySQL and Postgres refuse all connections without a password Travis should still work without db passwords, should just add ON_TRAVIS=1 in Travis's env * Reverted some of my silly changes in index.js Fixed lint errors in some of example-postgres.js * Fixed the rest of the lint errors in example-postgres.js * Fixed some ignored lint errors * Eslint ignored index.d.ts * Fixed bug in index.d.ts where I forgot to add new to an interface * Added travis env variable that signals to tests that it's in fact running in Travis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please squash my commits when merging, because some commits were more or less reverted and will confuse whoever looks back at them.