fix: Fix CPU balancing where calculations are done in float instead of int. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyptazy
changed the title
…f string. By: @glitchvern Fixes: #75
gyptazy
force-pushed
the
fix/75-fix-cpu-balancing-calculations
branch
from
315327f
to
d44da07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Fix CPU balancing where calculations are done in float instead of int.
This PR fixes handling of CPU based balancing by avoiding rounding issues treating the values in float instead of integer.
Thanks to @glitchvern by providing the patch and testing in #75.
Patch also passed by test runs, so we're good to go and may include this into the upcoming 1.0.4 release.
By: @glitchvern
Fixes: #75