encoder: write out buffer before starting flush or finish #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem here was that the buffer could still have some data in it at the time it is overwritten. None of the existing tests tested partial writes at all. To test this, generalize `WriteWithReject` to also handle partial writes.
|
FYI this is a critical corruption bug, so it would be good to have this landed and a new release made soonish. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem here was that the buffer could still have some data in it at the
time it is overwritten. This would cause corruption, demonstrated by the
tests if run without the corresponding code changes.
None of the existing tests tested partial writes at all. To test this,
generalize
WriteWithRejectto also handle partial writes.