Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap progress to 0.99 if experiment is still running #861

Merged
merged 3 commits into from
Sep 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions llm_studio/app_utils/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -1850,6 +1850,13 @@ def get_experiments(
# make sure progress is 100% for finished experiments
df.loc[df.status == "finished", "progress"] = "1.0"

# make sure that if experiment is running the progress is at most 99%
df.loc[
(df.status == "running")
& (pd.to_numeric(df.progress, errors="coerce") > 0.99),
"progress",
] = ".99"

df["info"] = np.where(
(df["status"] == "running") & (df["eta"] != ""),
df["eta"].apply(lambda x: f"ETA: {x}"),
Expand Down