chore: Refactor. #1597

h2oai · Sep 27, 2022 · 313f5e2 · 313f5e2
1 parent aa11368
commit 313f5e2
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/ui/src/image_annotator.tsx b/ui/src/image_annotator.tsx
@@ -212,7 +212,6 @@ export const XImageAnnotator = ({ model }: { model: ImageAnnotator }) => {
 
       switch (activeShape) {
         case 'rect': {
-          // TODO: Fix rect selection.
           rectRef.current?.onClick(e, cursor_x, cursor_y, setDrawnShapes, activeTag, start)
           break
         }

diff --git a/ui/src/image_annotator_rect.ts b/ui/src/image_annotator_rect.ts
@@ -53,10 +53,9 @@ export class RectAnnotator {
   }
 
   onClick = (e: React.MouseEvent, cursor_x: U, cursor_y: U, setDrawnShapes: (value: React.SetStateAction<DrawnShape[]>) => void, tag: S, start?: Position) => {
-    let newRect = null
     if (start && !this.resizedCorner) {
       const rect = this.createRect(start.x, cursor_x, start.y, cursor_y)
-      if (rect) newRect = ({ shape: { rect: rect }, tag })
+      if (rect) setDrawnShapes(drawnShapes => [{ shape: { rect }, tag }, ...drawnShapes])
     }
 
     if (!this.resizedCorner && !start?.dragging && e.type !== 'mouseleave') {
@@ -68,8 +67,6 @@ export class RectAnnotator {
 
     this.resizedCorner = undefined
     this.movedRect = undefined
-
-    return newRect
   }
 
   onMouseDown(cursor_x: U, cursor_y: U, rect: ImageAnnotatorRect) {