Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file_upload required parameter #1503

Closed
azim-b opened this issue Jun 15, 2022 · 0 comments · Fixed by #1633
Closed

file_upload required parameter #1503

azim-b opened this issue Jun 15, 2022 · 0 comments · Fixed by #1633
Assignees
@marek-mihok
Labels
feature Feature request good first issue Contributions welcome! ui Related to UI

Comments

@azim-b
Copy link
Contributor

azim-b commented Jun 15, 2022

Is your feature request related to a problem? Please describe

No

Describe the solution you'd like

Support for required parameter for ui.file_upload(), for example like ui.dropdown() or ui.combobox()

Describe alternatives you've considered

Responding if file upload is not done by checking q.args after the form is submitted.
@azim-b azim-b added the feature Feature request label Jun 15, 2022
@mturoci mturoci added the ui Related to UI label Jun 16, 2022
@marek-mihok marek-mihok self-assigned this Sep 2, 2022
@mturoci mturoci added the good first issue Contributions welcome! label Sep 12, 2022
marek-mihok added a commit that referenced this issue Sep 21, 2022
@marek-mihok
feat: add required prop to ui.file_upload #1503
d53fce8
marek-mihok added a commit that referenced this issue Sep 21, 2022
@marek-mihok
feat: add required prop to ui.file_upload #1503
f05c61e
@marek-mihok marek-mihok self-assigned this Sep 21, 2022
@marek-mihok marek-mihok mentioned this issue Sep 21, 2022
Merged
marek-mihok added a commit that referenced this issue Sep 21, 2022
@marek-mihok
chore: when label present, show asterisk with label #1503
d777ac9
marek-mihok added a commit that referenced this issue Sep 21, 2022
@marek-mihok
chore: add errorText into css variables #1503
d349985
marek-mihok added a commit that referenced this issue Sep 22, 2022
@marek-mihok
chore: refactor #1503
009cbfa
marek-mihok added a commit that referenced this issue Sep 22, 2022
@marek-mihok
feat: add required prop to ui.file_upload #1503
b824070
marek-mihok added a commit that referenced this issue Sep 22, 2022
@marek-mihok
chore: when label present, show asterisk with label #1503
3cd4beb
marek-mihok added a commit that referenced this issue Sep 22, 2022
@marek-mihok
chore: add errorText into css variables #1503
c389e87
marek-mihok added a commit that referenced this issue Sep 22, 2022
@marek-mihok
chore: refactor #1503
07a280f
marek-mihok added a commit that referenced this issue Sep 26, 2022
@marek-mihok
fix: add accidentaly removed styling back #1503
5f9897c
marek-mihok added a commit that referenced this issue Sep 26, 2022
@marek-mihok
feat: add required prop to ui.file_upload #1503
feed205
marek-mihok added a commit that referenced this issue Sep 26, 2022
@marek-mihok
chore: when label present, show asterisk with label #1503
431fc50
marek-mihok added a commit that referenced this issue Sep 26, 2022
@marek-mihok
chore: add errorText into css variables #1503
d112c74
marek-mihok added a commit that referenced this issue Sep 26, 2022
@marek-mihok
chore: refactor #1503
4be57a2
marek-mihok added a commit that referenced this issue Sep 26, 2022
@marek-mihok
fix: add accidentaly removed styling back #1503
10d62a8
mturoci pushed a commit that referenced this issue Sep 26, 2022
@marek-mihok
feat: Add required prop to ui.file_upload #1503 (#1633)
bca7d7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marek-mihok marek-mihok

Labels
feature Feature request good first issue Contributions welcome! ui Related to UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add required prop to ui.file_upload h2oai/wave
3 participants
@marek-mihok @mturoci @azim-b