Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image zoom when clicking on an image #1542

Closed
ledell opened this issue Jul 14, 2022 · 1 comment · Fixed by #1662
Closed

Image zoom when clicking on an image #1542

ledell opened this issue Jul 14, 2022 · 1 comment · Fixed by #1662
Assignees
@marek-mihok
Labels
feature Feature request ui Related to UI

Comments

@ledell
Copy link

ledell commented Jul 14, 2022

On some websites, if you click on an image, it will blow up to fullscreen mode (with an "x" to exit the view). Maybe we can add this functionality to Wave?
@ledell ledell added the feature Feature request label Jul 14, 2022
@mturoci mturoci added the ui Related to UI label Jul 14, 2022
@dott1718
Copy link

It would make sense to implement a similar user experience of image zoom as for image_annotator component #1598

@aalencar aalencar mentioned this issue Sep 15, 2022
Open
marek-mihok added a commit that referenced this issue Sep 26, 2022
@marek-mihok
feat: add lightbox support for single image #1542
6c20276
marek-mihok added a commit that referenced this issue Sep 26, 2022
@marek-mihok
feat: add multiple image support #1542
44df791
marek-mihok added a commit that referenced this issue Sep 28, 2022
@marek-mihok
feat: add dynamic loading for image nav, add zoom image support, add …
f9d7ddd 
…image captions, improved styling #1542
marek-mihok added a commit that referenced this issue Oct 3, 2022
@marek-mihok
chore: improve gallery scrolling behavior #1542
d28c022
marek-mihok added a commit that referenced this issue Oct 4, 2022
@marek-mihok
fix: resolve scrollbar jump by providing placeholder for lazy loaded …
6d036f2 
…images #1542
marek-mihok added a commit that referenced this issue Oct 5, 2022
@marek-mihok
chore: remove unnecessary stylings #1542
d795ed1
marek-mihok added a commit that referenced this issue Oct 5, 2022
@marek-mihok
chore: set default scroll position, add key controls, refactor #1542
7eac925
marek-mihok added a commit that referenced this issue Oct 5, 2022
@marek-mihok
chore: code refactoring #1542
74e62a0
marek-mihok added a commit that referenced this issue Oct 5, 2022
@marek-mihok
feat: add lightbox support for single image #1542
8cf6d58
marek-mihok added a commit that referenced this issue Oct 5, 2022
@marek-mihok
feat: add multiple image support #1542
a94292a
marek-mihok added a commit that referenced this issue Oct 5, 2022
@marek-mihok
feat: add dynamic loading for image nav, add zoom image support, add …
fd619b6 
…image captions, improved styling #1542
marek-mihok added a commit that referenced this issue Oct 5, 2022
@marek-mihok
chore: improve gallery scrolling behavior #1542
dea52b5
marek-mihok added a commit that referenced this issue Oct 5, 2022
@marek-mihok
fix: resolve scrollbar jump by providing placeholder for lazy loaded …
daabd8e 
…images #1542
marek-mihok added a commit that referenced this issue Oct 5, 2022
@marek-mihok
chore: remove unnecessary stylings #1542
f787a79
marek-mihok added a commit that referenced this issue Oct 5, 2022
@marek-mihok
chore: set default scroll position, add key controls, refactor #1542
e25903f
marek-mihok added a commit that referenced this issue Oct 5, 2022
@marek-mihok
chore: code refactoring #1542
10782a5
marek-mihok added a commit that referenced this issue Oct 6, 2022
@marek-mihok
chore: image lightbox general refactor, polished scroll behavior, opt…
385737d 
…imizations #1542
marek-mihok added a commit that referenced this issue Oct 6, 2022
@marek-mihok
fix: prevent single image lightbox crash #1542
558b048
marek-mihok added a commit that referenced this issue Oct 6, 2022
@marek-mihok
chore: single image lightbox optimization #1542
dd07587
marek-mihok added a commit that referenced this issue Oct 6, 2022
@marek-mihok
feat: add lightbox support for single image #1542
5fe00b1
marek-mihok added a commit that referenced this issue Oct 6, 2022
@marek-mihok
feat: add multiple image support #1542
4406904
marek-mihok added a commit that referenced this issue Oct 6, 2022
@marek-mihok
feat: add dynamic loading for image nav, add zoom image support, add …
3582e51 
…image captions, improved styling #1542
marek-mihok added a commit that referenced this issue Oct 6, 2022
@marek-mihok
chore: improve gallery scrolling behavior #1542
86472c6
marek-mihok added a commit that referenced this issue Oct 20, 2022
@marek-mihok
chore: remove unnecessary div wrapping from lightbox arrows #1542
68b5c61
marek-mihok added a commit that referenced this issue Oct 21, 2022
@marek-mihok
chore: refactor and code cleaning #1542
9dbab94
marek-mihok added a commit that referenced this issue Oct 21, 2022
@marek-mihok
fix: lightbox type issues #1542
d00f022
marek-mihok added a commit that referenced this issue Oct 23, 2022
@marek-mihok
fix: remove type error for dialogB() and sidePanelB() #1542
08b121d
marek-mihok added a commit that referenced this issue Oct 23, 2022
@marek-mihok
feat: add lightbox support for single image #1542
bdf1f6b
marek-mihok added a commit that referenced this issue Oct 23, 2022
@marek-mihok
feat: add multiple image support #1542
c9e97e6
marek-mihok added a commit that referenced this issue Oct 23, 2022
@marek-mihok
feat: add dynamic loading for image nav, add zoom image support, add …
8e6cd68 
…image captions, improved styling #1542
marek-mihok added a commit that referenced this issue Oct 23, 2022
@marek-mihok
chore: improve gallery scrolling behavior #1542
00b3390
marek-mihok added a commit that referenced this issue Oct 23, 2022
@marek-mihok
fix: resolve scrollbar jump by providing placeholder for lazy loaded …
27a42bc 
…images #1542
marek-mihok added a commit that referenced this issue Oct 23, 2022
@marek-mihok
chore: remove unnecessary stylings #1542
891c544
marek-mihok added a commit that referenced this issue Oct 23, 2022
@marek-mihok
chore: set default scroll position, add key controls, refactor #1542
ed98e37
marek-mihok added a commit that referenced this issue Oct 23, 2022
@marek-mihok
chore: code refactoring #1542
f7def2e
marek-mihok added a commit that referenced this issue Oct 23, 2022
@marek-mihok
chore: image lightbox general refactor, polished scroll behavior, opt…
1e75f71 
…imizations #1542
marek-mihok added a commit that referenced this issue Oct 23, 2022
@marek-mihok
chore: single image lightbox optimization #1542
5c55e04
marek-mihok added a commit that referenced this issue Oct 23, 2022
@marek-mihok
chore: improved code readability, themable active color, refactor #1542
8548116
marek-mihok added a commit that referenced this issue Oct 23, 2022
@marek-mihok
chore: add wider browser support for image nav scrolling #1542
2434697
marek-mihok added a commit that referenced this issue Oct 23, 2022
@marek-mihok
fix: prevent default keyDown events like scrolling the focused area, …
d5d4bdf 
…refactor #1542
marek-mihok added a commit that referenced this issue Oct 23, 2022
@marek-mihok
feat: make lightbox singleton #1542
7f47f68
marek-mihok added a commit that referenced this issue Oct 23, 2022
@marek-mihok
chore: add non-working test mock for IntersectionObserver #1542
81d8b23
marek-mihok added a commit that referenced this issue Oct 23, 2022
@marek-mihok
fix: prevent IntersectionObserver from being unintialized #1542
92fde6f
marek-mihok added a commit that referenced this issue Oct 23, 2022
@marek-mihok
chore: remove unnecessary div wrapping from lightbox arrows #1542
85c8e5b
marek-mihok added a commit that referenced this issue Oct 23, 2022
@marek-mihok
chore: refactor and code cleaning #1542
8454fe8
marek-mihok added a commit that referenced this issue Oct 23, 2022
@marek-mihok
fix: lightbox type issues #1542
74fb756
marek-mihok added a commit that referenced this issue Oct 23, 2022
@marek-mihok
fix: remove type error for dialogB() and sidePanelB() #1542
f64521a
marek-mihok added a commit that referenced this issue Oct 23, 2022
@marek-mihok
chore: add correct typing for image lightboxProps #1542
5702a12
marek-mihok added a commit that referenced this issue Oct 23, 2022
@marek-mihok
chore: reogranize getImageSrc exported fn #1542
44c042d
marek-mihok added a commit that referenced this issue Oct 23, 2022
@marek-mihok
chore: reuse existing style refactor #1542
a279ca9
marek-mihok added a commit that referenced this issue Oct 24, 2022
@marek-mihok
chore: final refactor #1542
92447e1
mturoci pushed a commit that referenced this issue Oct 24, 2022
@marek-mihok
feat: Image lightbox component - fullscreen image detail. #1542 (#1662)
6ae48be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marek-mihok marek-mihok

Labels
feature Feature request ui Related to UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Image lightbox component for image zoom and image grid h2oai/wave
4 participants
@ledell @dott1718 @marek-mihok @mturoci