Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download table content with icons as CSV #1626

Closed
shamilh2o opened this issue Sep 16, 2022 · 11 comments · Fixed by #1674
Closed

Download table content with icons as CSV #1626

shamilh2o opened this issue Sep 16, 2022 · 11 comments · Fixed by #1674
Assignees
Labels
feature Feature request good first issue Contributions welcome! ui Related to UI

Comments

@shamilh2o
Copy link

shamilh2o commented Sep 16, 2022

Is your feature request related to a problem? Please describe

I was using default download feature in the wave tables. In my table it contains some icons which I need to display in downloaded CSV file as it is. But it shows some other characters in cells where those icons placed.

Table UI:
image

Expected cell in downloaded CSV:
image

Currently receiving output:
image

Describe the solution you'd like

Contain icons used in wave table cells as it is in the downloaded CSV file.

Describe alternatives you've considered

Use separate button to download CSV after including meaningful text instead of icons. But this not includes icons as it is. Just replacing icons with meaningful names.

Additional context

Discussion is in #1624
cc: @mturoci

@shamilh2o shamilh2o added the feature Feature request label Sep 16, 2022
@mturoci mturoci added ui Related to UI good first issue Contributions welcome! labels Sep 19, 2022
@mturoci
Copy link
Collaborator

mturoci commented Sep 19, 2022

Implementation notes: table download function creates blob that doesn't keep unicode chars and needs to be rewritten as described here.

@InfasMohammed
Copy link

Hi, can I take up this issue?

@mturoci
Copy link
Collaborator

mturoci commented Sep 27, 2022

Hi @InfasMohammed. Sure, it's yours.

@InfasMohammed
Copy link

image
i have this issue

@mturoci
Copy link
Collaborator

mturoci commented Oct 3, 2022

Please follow the dev setup instructions in contribution guidelines. Once done, run the table.py example as it's relevant to this issue.

Note that your 4 days have already passed though which means this issue is again up for grabs for anyone interested. You may continue to work on it on your own if you want though.

@InfasMohammed
Copy link

I will continue

@JacksonIsaac
Copy link
Contributor

Is this issue still up for grabs ? I have the wave server running

@mturoci
Copy link
Collaborator

mturoci commented Oct 17, 2022

Yes, go for it @JacksonIsaac!

@JacksonIsaac
Copy link
Contributor

I tried the changes, and tested by changing the examples/table files to have a unicode object. It works, but I would like to reproduce the same above scenario.

Any ideas on how I can reproduce the above please ?

@mturoci
Copy link
Collaborator

mturoci commented Oct 21, 2022

You need to create a table with '❌' and '✅' as described here.

@JacksonIsaac
Copy link
Contributor

Figured it out, thanks :) I spent hours on this, just to realize I myself had a bug in my example unicode :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request good first issue Contributions welcome! ui Related to UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants