Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment of table values #1659

Closed
vopani opened this issue Oct 5, 2022 · 5 comments · Fixed by #1670
Closed

Alignment of table values #1659

vopani opened this issue Oct 5, 2022 · 5 comments · Fixed by #1670
Assignees
Labels
feature Feature request good first issue Contributions welcome! ui Related to UI

Comments

@vopani
Copy link
Contributor

vopani commented Oct 5, 2022

Is your feature request related to a problem? Please describe

Allowing different alignments of values in a table can beautify UI in some use-cases.

Describe the solution you'd like

Allow user to left / center / right align the values of a column (something like justify in ui.table_column with default='left' so nothing breaks / changes in UI of existing apps).

Additional context

This is purely for nicer UI, especially in scenarios when some of the table cell elements are markdown (where content can be center-aligned), it'll make it more consistent visually.

@vopani vopani added the feature Feature request label Oct 5, 2022
@mturoci mturoci added ui Related to UI good first issue Contributions welcome! labels Oct 5, 2022
@Pooja444
Copy link
Contributor

Pooja444 commented Oct 8, 2022

@mturoci I would like to work on this issue, can it be assigned to me, please? I have worked on the issue #1577 and now I have a good knowledge of how to develop UI changes so it'll probably help with this issue 😁

@mturoci
Copy link
Collaborator

mturoci commented Oct 10, 2022

Please go ahead @Pooja444!

@RedJOe-0608
Copy link

I'd like to contribute to this issue! Can I work on it?

@mturoci
Copy link
Collaborator

mturoci commented Oct 12, 2022

Hi @RedJOe-0608, this issue is currently taken by @Pooja444 but feel free to pick some other issue - there are still many left.

@Pooja444
Copy link
Contributor

Thanks for assigning this to me @mturoci, I have raised a PR for this issue - #1670
This issue was awesome and I had fun contributing to it! Please review and let me know if I need to make any changes, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request good first issue Contributions welcome! ui Related to UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants