Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display image in a graphics_card #1817

Closed
mturoci opened this issue Jan 31, 2023 Discussed in #1816 · 15 comments · Fixed by #2373
Closed

Display image in a graphics_card #1817

mturoci opened this issue Jan 31, 2023 Discussed in #1816 · 15 comments · Fixed by #2373
Labels
feature Feature request good first issue Contributions welcome! ui Related to UI

Comments

@mturoci
Copy link
Collaborator

mturoci commented Jan 31, 2023

via @DeeJaayArgh

Discussed in #1816

Originally posted by DeeJaayArgh January 30, 2023
I was looking in the docs about displaying an image in a ui.graphics_card and didn't find a good example. I've been able to display a png file in an image_card but I'd like to get it in a ui.graphics_card to use as part of a scene. Is this possible?

Description

Add new image (for base64) and path for regular image URLs to the existing graphics_card. If any of those 2 attributes is specified, render the image as a card background. Graphics drawing should happen "on top of the image".

@mturoci mturoci added ui Related to UI feature Feature request good first issue Contributions welcome! labels Jan 31, 2023
@mturoci mturoci changed the title Displayi image in a graphics_card Display image in a graphics_card Jan 31, 2023
@theVJagrawal
Copy link

Can I work on this issue? I am pretty new to open source stuff

@mturoci
Copy link
Collaborator Author

mturoci commented Feb 1, 2023

Sure, go ahead @theVJagrawal!

@dohrisalim
Copy link

Are you still working on this issue @theVJagrawal?
@mturoci could you give us more information about this issue so we can get started on a fix? What file should we make changes in?

@mturoci
Copy link
Collaborator Author

mturoci commented Feb 8, 2023

You can go ahead @dohrisali.

What file should we make changes in?

Try to make some due diligence yourself first. All the necessary info should be in the issue description. In case you have any further questions, drop them here.

@Pratyakshshiv
Copy link

@mturoci is this issue still open if yes can you please assign this to me?

@mturoci
Copy link
Collaborator Author

mturoci commented Jun 22, 2023

All yours @Pratyakshshiv, go ahead.

@Pratyakshshiv
Copy link

All yours @Pratyakshshiv, go ahead.

Thanks can you please guide me which file i have to make this changes to i tried to find the graphics_card which was mentioned in the description but looks like it's not a file.

@mturoci
Copy link
Collaborator Author

mturoci commented Jun 27, 2023

See the contributing guide first.

@mturoci
Copy link
Collaborator Author

mturoci commented Jul 17, 2023

Any updates @Pratyakshshiv?

@Gingaaa
Copy link

Gingaaa commented Aug 20, 2023

Hey I have worked on around 7-8 company based project, but never countribute to open source this is my first time can you assign me this task.

@mturoci
Copy link
Collaborator Author

mturoci commented Aug 21, 2023

Go ahead @Gingaaa. No assignment necessary :)

@nishitiwari22
Copy link

I am a beginner in open source and I really want to contribute to this task, may I?

@mturoci
Copy link
Collaborator Author

mturoci commented Oct 2, 2023

No need to ask for permission. Go ahead :) If you are new, I recommend going through Contributing guide first.

@bharateshwq
Copy link

This issue seems to be open,
i will start to work on it

@dbranley
Copy link
Contributor

Hi, I submitted a PR for this change request. Let me know how it looks and if you would like any changes. Thanks!

dbranley added a commit to dbranley/wave that referenced this issue Aug 6, 2024
…s.test.tsx changes, added new graphics example, also added graphics to widgets section of docs h2oai#1817
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request good first issue Contributions welcome! ui Related to UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants