Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown button #1887

Closed
dott1718 opened this issue Mar 13, 2023 · 2 comments · Fixed by #1906
Closed

Dropdown button #1887

dott1718 opened this issue Mar 13, 2023 · 2 comments · Fixed by #1906
Assignees
@marek-mihok
Labels
feature Feature request ui Related to UI

Comments

@dott1718
Copy link

Is your feature request related to a problem? Please describe

A new UI component - a dropdown button similar to e.g. bootstrap https://getbootstrap.com/docs/4.0/components/dropdowns/

image

Describe the solution you'd like

A dropdown button to group several related actions under a single UI element.
@dott1718 dott1718 added the feature Feature request label Mar 13, 2023
@lo5
Copy link
Member

lo5 commented Mar 13, 2023

The button function can probably accept an optional list like this: https://nitro.h2o.ai/guide/buttons/#add-a-menu

@mturoci mturoci added the ui Related to UI label Mar 14, 2023
marek-mihok added a commit that referenced this issue Mar 23, 2023
@marek-mihok
feat: initial implementation #1887
7e24a7c
marek-mihok added a commit that referenced this issue Mar 23, 2023
@marek-mihok
chore: update py example #1887
6376771
marek-mihok added a commit that referenced this issue Mar 24, 2023
@marek-mihok
chore: rename commands to choices #1887
f74a169
@mturoci
Copy link
Collaborator

mturoci commented Mar 24, 2023

@dott1718 one more alternative is to use ui.menu.

marek-mihok added a commit that referenced this issue Mar 24, 2023
@marek-mihok
chore: add tests, docs; API refactor #1887
fa2d85d
marek-mihok added a commit that referenced this issue Mar 27, 2023
@marek-mihok
chore: update test cases #1887
73b6035
marek-mihok added a commit that referenced this issue Mar 27, 2023
@marek-mihok
chore: update docs #1887
a9467d7
@marek-mihok marek-mihok mentioned this issue Mar 27, 2023
Merged
marek-mihok added a commit that referenced this issue Mar 28, 2023
@marek-mihok
chore: update API description for icon prop #1887
5c72201
marek-mihok added a commit that referenced this issue Mar 28, 2023
@marek-mihok
chore: update test with hash prefix #1887
3625119
marek-mihok added a commit that referenced this issue Mar 30, 2023
@marek-mihok
chore: use commands instead of choices, remove path and disabled props …
de4968e 
…#1887
marek-mihok added a commit that referenced this issue Mar 30, 2023
@marek-mihok
feat: add sub-items support for button commands context menu #1887
bf854cd
marek-mihok added a commit that referenced this issue Apr 6, 2023
@marek-mihok
fix: remove scrollbar from contextual sub-menus #1887
83ebe67
marek-mihok added a commit that referenced this issue Apr 6, 2023
@marek-mihok
fix: add correct types #1887
e641248
marek-mihok added a commit that referenced this issue Apr 11, 2023
@marek-mihok
chore: give subComponentStyles the correct type #1887
6005430
marek-mihok added a commit that referenced this issue Apr 11, 2023
@marek-mihok
chore: simplify tour example, extend docs examples #1887
e13bb31
marek-mihok added a commit that referenced this issue Apr 11, 2023
@marek-mihok
feat: initial implementation #1887
d2bc0d9
marek-mihok added a commit that referenced this issue Apr 11, 2023
@marek-mihok
chore: update py example #1887
667c0e3
marek-mihok added a commit that referenced this issue Apr 11, 2023
@marek-mihok
chore: rename commands to choices #1887
976d85b
marek-mihok added a commit that referenced this issue Apr 11, 2023
@marek-mihok
chore: add tests, docs; API refactor #1887
4ec0a1b
marek-mihok added a commit that referenced this issue Apr 11, 2023
@marek-mihok
chore: update test cases #1887
7b3cc60
marek-mihok added a commit that referenced this issue Apr 11, 2023
@marek-mihok
chore: update docs #1887
cef6547
marek-mihok added a commit that referenced this issue Apr 11, 2023
@marek-mihok
chore: update API description for icon prop #1887
4b72934
marek-mihok added a commit that referenced this issue Apr 11, 2023
@marek-mihok
chore: update test with hash prefix #1887
700cc06
marek-mihok added a commit that referenced this issue Apr 11, 2023
@marek-mihok
chore: use commands instead of choices, remove path and disabled props …
7dde5fe 
…#1887
marek-mihok added a commit that referenced this issue Apr 11, 2023
@marek-mihok
feat: add sub-items support for button commands context menu #1887
6173f66
marek-mihok added a commit that referenced this issue Apr 11, 2023
@marek-mihok
fix: remove scrollbar from contextual sub-menus #1887
2e5606a
marek-mihok added a commit that referenced this issue Apr 11, 2023
@marek-mihok
fix: add correct types #1887
95eddff
marek-mihok added a commit that referenced this issue Apr 11, 2023
@marek-mihok
chore: give subComponentStyles the correct type #1887
66c3b26
marek-mihok added a commit that referenced this issue Apr 11, 2023
@marek-mihok
chore: simplify tour example, extend docs examples #1887
69c6cb2
marek-mihok added a commit that referenced this issue Apr 11, 2023
@marek-mihok
chore: add correct styling for icon split button #1887
1c75c6b
marek-mihok added a commit that referenced this issue Apr 18, 2023
@marek-mihok
chore: update docs description #1887
bb8e9b1
marek-mihok added a commit that referenced this issue Apr 18, 2023
@marek-mihok
chore: update API description for button commands #1887
9f73da5
marek-mihok added a commit that referenced this issue Apr 18, 2023
@marek-mihok
chore: remove unnecessary data prop from items #1887
9918adc
marek-mihok added a commit that referenced this issue Apr 18, 2023
@marek-mihok
chore: reuse toolbar toCommands function #1887
60cc012
marek-mihok added a commit that referenced this issue Apr 18, 2023
@marek-mihok
chore: reuse stylings #1887
30f0121
marek-mihok added a commit that referenced this issue Apr 18, 2023
@marek-mihok
chore: unify contextual menu styles with the rest #1887
5f5034c
marek-mihok added a commit that referenced this issue Apr 18, 2023
@marek-mihok
chore: set directional hint corner #1887
d4e6b0d
marek-mihok added a commit that referenced this issue Apr 18, 2023
@marek-mihok
fix: make setting wave args consistent with other commands #1887
6607a09
mturoci added a commit that referenced this issue Apr 19, 2023
@mturoci
docs: Small improvements. #1887
0411cfb
mturoci pushed a commit that referenced this issue Apr 19, 2023
@marek-mihok
feat: Split button #1887 (#1906)
7388f4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marek-mihok marek-mihok

Labels
feature Feature request ui Related to UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Dropdown button #1887 h2oai/wave
4 participants
@lo5 @dott1718 @marek-mihok @mturoci