Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support external links for ui.nav_item #1952

Closed
marek-mihok opened this issue Apr 28, 2023 · 0 comments · Fixed by #1958
Closed

Support external links for ui.nav_item #1952

marek-mihok opened this issue Apr 28, 2023 · 0 comments · Fixed by #1958
Labels
feature Feature request ui Related to UI

Comments

@marek-mihok
Copy link
Contributor

Via #1204: ui.nav_item currently supports hash-change navigation only.

It would be nice to introduce a new path property for ui.nav_item to support opening external websites from side navigation.
@marek-mihok marek-mihok added ui Related to UI feature Feature request labels Apr 28, 2023
marek-mihok added a commit that referenced this issue May 2, 2023
@marek-mihok
feat: add path attribute to ui.nav_item #1952
b79b5a2
marek-mihok added a commit that referenced this issue May 2, 2023
@marek-mihok
chore: add test, update docs #1952
9b04d7b
@marek-mihok marek-mihok mentioned this issue May 2, 2023
Merged
marek-mihok added a commit that referenced this issue May 2, 2023
@marek-mihok
chore: update py example, update example img #1952
04dc963
marek-mihok added a commit that referenced this issue May 2, 2023
@marek-mihok
docs: change navigation path description #1952
9b352bc
mturoci pushed a commit that referenced this issue May 2, 2023
@marek-mihok
feat: Support external links in navigation #1952 (#1958)
c4750c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Feature request ui Related to UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Support external links in navigation h2oai/wave
1 participant
@marek-mihok