Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select All on 2nd filter in table not showing checked checkboxes #2386

Closed
dbranley opened this issue Aug 27, 2024 · 0 comments · Fixed by #2387
Closed

Select All on 2nd filter in table not showing checked checkboxes #2386

dbranley opened this issue Aug 27, 2024 · 0 comments · Fixed by #2387
Labels
bug Bug in code ui Related to UI

Comments

@dbranley
Copy link
Contributor

Wave SDK Version, OS

v1.5.0, MacOS

Actual behavior

This was initially reported during a discussion in the PR for table filter counts.

When you have a table with 2 or more filterable columns, you can get into a situation where clicking the Select All button on the 2nd filter context menu does not change the state of the checkboxes for the filters. This happens when you filter something in one of the columns and then try to filter in another column.

Expected behavior

Clicking Select All or Deselect All on a filter context menu should always change the rendered state of the checkboxes displayed.

Steps To Reproduce

  1. Go to a table with 2 filterable columns.
  2. Click the filter icon on the 1st column and from the filter context menu selected one of the filter checkboxes
  3. Notice that the table updates as expected and the filter count for the column displays 1
  4. Click the filter icon on the 2nd column and from the filter context menu click the Select All button
  5. Notice that none of the checkboxes on the filter context menu are selected, this is incorrect
  6. Notice that the filter count for the column displays the correct number, which means filtering worked even though the checkboxes were not checked
  7. Click the filter icon on the 2nd column again
  8. Notice all the checkboxes are rendered as checked

Here is a short video showing the issue:

IssueXXXX_bug.mov
@dbranley dbranley added the bug Bug in code label Aug 27, 2024
dbranley added a commit to dbranley/wave that referenced this issue Aug 28, 2024
…her than explicitly returning or , added a new test h2oai#2386
mturoci added a commit that referenced this issue Sep 3, 2024
@mturoci mturoci added the ui Related to UI label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug in code ui Related to UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants