-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tour not working on Windows 10 #397
Comments
++ |
https://docs.python.org/3.7/library/asyncio-platforms.html#subprocess-support-on-windows
import asyncio
asyncio.set_event_loop_policy(
asyncio.WindowsProactorEventLoopPolicy())
asyncio.run(your_code()) |
I made it work on my windows machine by doing the following. looks like a when we do asyncio.set_event_loop_policy(
asyncio.WindowsProactorEventLoopPolicy()) to https://github.com/encode/uvicorn/blob/master/uvicorn/loops/asyncio.py fixed the issue reported above. but I got another error
based on the advice from here: appveyor/ci#1995 (comment) I made the following changes to env = dict(
SYSTEMROOT=os.environ.get('SYSTEMROOT'),
H2O_WAVE_EXTERNAL_ADDRESS=f'http://{_app_host}:{_app_port}'
)
self.process = await asyncio.create_subprocess_exec(
sys.executable, '-m', 'uvicorn', '--port', _app_port, f'examples.{self.name}:main', env=env,
) and it all worked. |
I experienced this issue as well |
Thank you for reporting - we have a solution; currently testing. |
Windows does not support SelectorEventLoop. To support tour in all the platforms, replaced asyncio.create_subprocess_exec() with python subprocess. Fixes: #397
Windows does not support SelectorEventLoop. To support tour in all the platforms, replaced asyncio.create_subprocess_exec() with python subprocess. Fixes: #397
Windows does not support SelectorEventLoop. To support tour in all the platforms, replaced asyncio.create_subprocess_exec() with python subprocess. Fixes: #397
…our (#429) * Replace asyncio.create_subprocess_exec() with python subprocess for tour Windows does not support SelectorEventLoop. To support tour in all the platforms, replaced asyncio.create_subprocess_exec() with python subprocess. Fixes: #397 * Introduce review suggestions * Introduce local variable to hold the reference to env * Introduce local variable to hold the reference to env
Thanks for your patience! You should be able to get the tour working on Windows by replacing your We'll push this out in the next release. |
Thanks! Confirmed it now works. |
Wave SDK Version, OS
0.10.0, Windows 10, Python 3.7.8
Actual behavior
When I try and run the tour, I get a NotImplementedError message in the console. The webapp fails to load also giving me the same error as in the console.
Expected behavior
I expected the tour to run
Steps To Reproduce
I did find these posts relating to asyncio and creating a sub-process in windows but I the suggestion there didn't work.
https://stackoverflow.com/questions/45699932/asyncio-stdout-failing
https://docs.python.org/3/library/asyncio-subprocess.html#windows-event-loop
The text was updated successfully, but these errors were encountered: