-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Image annotator #1400
feat: Image annotator #1400
Conversation
Thank you @mturoci, the component looks great! We will provide more feedback as soon as we can try it out. |
Demo looks great 🎸! It's not clear to me how |
I updated the existing example to show predefined annotation. The basic reasoning is:
|
@lo5 one more thing that is worth discussing is the image aspect ratio. Since images to be annotated can be various sizes, we have basically 2 options:
Since I chose the second option as it is more UX-friendly, I had to make adjustments to the coordinates based on the aspect ratio so that developers can specify and receive coordinates relative to the original size of their img. Example: Original img: 100x100 with coordinates 10,10. The proposed approach makes sense to me, but feel free to point out any alternatives as you see fit. |
OK, so if I'm understanding this correctly, |
Your approach sounds good to me. |
That's right. |
Co-authored-by: lo5 <[email protected]>
Co-authored-by: lo5 <[email protected]>
Co-authored-by: lo5 <[email protected]>
Co-authored-by: lo5 <[email protected]>
Co-authored-by: lo5 <[email protected]>
Co-authored-by: lo5 <[email protected]>
Co-authored-by: lo5 <[email protected]>
Co-authored-by: lo5 <[email protected]>
Co-authored-by: lo5 <[email protected]>
Co-authored-by: lo5 <[email protected]>
Co-authored-by: lo5 <[email protected]>
Co-authored-by: lo5 <[email protected]>
Co-authored-by: lo5 <[email protected]>
Co-authored-by: lo5 <[email protected]>
Co-authored-by: lo5 <[email protected]>
Co-authored-by: lo5 <[email protected]>
Thanks for the thorough review @lo5! All the comments were addressed and the branch rebased. Could you please give it one last quick glance and if it looks good to you, we can merge. |
Demo
Screen.Recording.2022-05-04.at.3.05.02.PM.mov
Proposed API
Returning
ImageAnnotatorItem
.@lo5 please have a look at the API - I tried to design it in a way so that we can support multiple shapes (circles/paths) in future as well. Let me know if you see room for improvement though.
Notes
cc @dott1718 for shallow feedback based on just video. I expect more detailed feedback after you play around with it in nightly.
Closes #1323