-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow file upload cancel #1410
Merged
Merged
Allow file upload cancel #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mturoci
requested changes
Jun 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @marek-mihok! A few comments from me. Please test the proposed changes cross-browser.
marek-mihok
force-pushed
the
feat/issue-1205
branch
from
June 6, 2022 09:17
88d9b61
to
bce64ca
Compare
marek-mihok
force-pushed
the
feat/issue-1205
branch
from
July 6, 2022 13:15
8724b90
to
dde60d8
Compare
mturoci
requested changes
Jul 7, 2022
marek-mihok
force-pushed
the
feat/issue-1205
branch
from
July 8, 2022 08:13
8e18c35
to
49c1cd1
Compare
mturoci
approved these changes
Jul 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @marek-mihok!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option to cancel upload for ui.file_upload component for both large and compact mode.
Screen.Recording.2022-05-10.at.14.41.20.mov
Screen.Recording.2022-05-10.at.15.00.11.mov
Closes #1205