Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow skipping Wave server TLS verification #1547 #1556

Merged
merged 4 commits into from
Aug 8, 2022
Merged

feat: Allow skipping Wave server TLS verification #1547 #1556

merged 4 commits into from
Aug 8, 2022

Conversation

mturoci
Copy link
Collaborator

@mturoci mturoci commented Jul 25, 2022

Closes #1547

@mturoci mturoci requested a review from lo5 as a code owner July 25, 2022 11:03
@mturoci mturoci requested a review from geomodular July 25, 2022 11:03
lo5
lo5 requested changes Aug 2, 2022
View reviewed changes
Copy link
Member

@lo5 lo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mturoci - minor (refactoring) changes.

cmd/wave/main.go Outdated Show resolved Hide resolved
cmd/wave/main.go Outdated Show resolved Hide resolved
cmd/wave/main.go Outdated Show resolved Hide resolved
website/docs/configuration.md Outdated Show resolved Hide resolved
@mturoci mturoci merged commit a6f37ae into master Aug 8, 2022
@mturoci mturoci deleted the feat/issue-1547 branch August 8, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lo5 lo5 lo5 requested changes

@geomodular geomodular Awaiting requested review from geomodular

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to turn off SSL cert verification when doing requests from Wave server (e.g. Keycloak)
2 participants
@mturoci @lo5