Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add proper err handling to site.download function and allow extensionless file downloads. #1627 #1635

Merged
merged 7 commits into from
Dec 9, 2022

Conversation

mturoci
Copy link
Collaborator

@mturoci mturoci commented Sep 22, 2022

  • Raise an err if there is any - same behavior like the rest of alike functions.
  • Create a file for the stream to write into only in case of 200 status code.

Needs discussion: #1627 (comment)

Closes #1627

Copy link
Member

@lo5 lo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mturoci.

@mturoci mturoci changed the title feat: Add proper err handling to site.download function. #1627 feat: Add proper err handling to site.download function and allow extensionless file downloads. #1627 Dec 9, 2022
@mturoci mturoci merged commit 39e1af1 into master Dec 9, 2022
@mturoci mturoci deleted the fix/issue-1627 branch December 9, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uploads fail if file has no extension
2 participants