Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove vertical scroll overflow in todo example #1680

Merged
merged 4 commits into from
Nov 2, 2022

Conversation

JacksonIsaac
Copy link
Contributor

Github issue

Fixes #776

Before output

before-tour-wave-todo

before-tour-wave-todo-add

After output

after-tour-wave-todo

after-tour-wave-todo-add

@JacksonIsaac
Copy link
Contributor Author

@mturoci The latest commit should fix all the examples, both horizontal and vertical scroll wherever I could notice improvement opportunities.

Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JacksonIsaac, a few more adjustments are necessary. I recommend completing this on your laptop screen rather than an external monitor so that you can see the scrollbars directly + it's how most of our users will do.

The following is a list of examples that need adjustments:

  • wide plot
  • wide article preview
  • form
  • textbox
  • table
  • table tags
  • image
  • image annotator
  • frame path
  • plot schema
  • plot form
  • plot pandas
  • vegalite form
  • vegalite flex
  • bokeh callbacks

Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JacksonIsaac!

@mturoci mturoci merged commit 73a567b into h2oai:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to tour.py
2 participants