fix: Make disabled ui.button icon and text colours consistent #1664 #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mturoci
requested changes
Nov 21, 2022
There was a problem hiding this comment.
Thanks @marek-mihok, we should ideally fix this globally for every Fluent button component (e.g. we use buttons for pagination in table etc.).
mturoci
requested changes
Nov 23, 2022
marek-mihok
force-pushed
the
feat/issue-1664
branch
from
4c07cb7
to
e560340
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides an override of icon colour for all disabled FluentUI buttons.
Screen.Recording.2022-11-21.at.11.32.15.mov
Closes #1664