feat: Add highlight for selected groups/rows #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mturoci
requested changes
Nov 29, 2022
mturoci
requested changes
Nov 30, 2022
marek-mihok
force-pushed
the
feat/issue-1713
branch
from
4cf3e57
to
79291ae
Compare
|
Thanks @marek-mihok. Could you please include updated screenshots with the new color for multiple themes so that we are sure they look fine beyond the default theme? |
|
@mturoci I used the "on hover" column header background color to make sure it will look fine for each of the themes. Please check the updated PR description if it is fine for you. |
mturoci
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1713