Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add highlight for selected groups/rows #1725

Merged
merged 4 commits into from
Dec 5, 2022
Merged

Conversation

marek-mihok
Copy link
Contributor

@marek-mihok marek-mihok commented Nov 28, 2022

image

image

image

image

image

image

image

image

image

image

image

image

image

image

Closes #1713

Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also show the checked checkbox if the whole group is selected? It seems it's only displayed on hover currently.

Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marek-mihok! Just a few small changes required.

ui/src/table.tsx Outdated Show resolved Hide resolved
ui/src/table.tsx Outdated Show resolved Hide resolved
@mturoci
Copy link
Collaborator

mturoci commented Dec 5, 2022

Thanks @marek-mihok. Could you please include updated screenshots with the new color for multiple themes so that we are sure they look fine beyond the default theme?

@marek-mihok
Copy link
Contributor Author

marek-mihok commented Dec 5, 2022

@mturoci I used the "on hover" column header background color to make sure it will look fine for each of the themes. Please check the updated PR description if it is fine for you.

Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @marek-mihok!

@mturoci mturoci merged commit aefd8cf into master Dec 5, 2022
@mturoci mturoci deleted the feat/issue-1713 branch December 5, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table (Group by) Selections No Longer Highlighted in Wave v22+
2 participants