Show a warning when at least one OIDC param detected, but not all are set #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mturoci
requested changes
Dec 6, 2022
mturoci
approved these changes
Dec 7, 2022
|
Minor note: GH can link and automatically close the issue after merge if the PR description contains |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1711.
Our code checks whether any of the OIDC required params are not empty in the function checkEmptyOIDCValues(). This function counts the amount of empty OIDC params. It returns a slice containing the empty OIDC params detected as well as a boolean which is true when some but not all OIDC params are empty.
After calling the function we just check if this boolean is true to display the required warning.
Collaborators:
@Qingyang-Sophia
@aruiz2