Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a warning when at least one OIDC param detected, but not all are set #1733

Merged
merged 6 commits into from
Dec 7, 2022

Conversation

aruiz2
Copy link
Contributor

@aruiz2 aruiz2 commented Dec 3, 2022

Closes #1711.

Our code checks whether any of the OIDC required params are not empty in the function checkEmptyOIDCValues(). This function counts the amount of empty OIDC params. It returns a slice containing the empty OIDC params detected as well as a boolean which is true when some but not all OIDC params are empty.

After calling the function we just check if this boolean is true to display the required warning.

Collaborators:
@Qingyang-Sophia
@aruiz2

Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aruiz2! Let's put everything into a single place and reuse the outputs of your helper function also here.

cmd/wave/main.go Outdated Show resolved Hide resolved
cmd/wave/main.go Outdated Show resolved Hide resolved
cmd/wave/main.go Outdated Show resolved Hide resolved
cmd/wave/main.go Outdated Show resolved Hide resolved
cmd/wave/main.go Outdated Show resolved Hide resolved
cmd/wave/main.go Outdated Show resolved Hide resolved
cmd/wave/main.go Show resolved Hide resolved
cmd/wave/main.go Outdated Show resolved Hide resolved
cmd/wave/main.go Outdated Show resolved Hide resolved
cmd/wave/main.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mturoci mturoci merged commit cf32b87 into h2oai:master Dec 7, 2022
@mturoci
Copy link
Collaborator

mturoci commented Dec 7, 2022

Minor note: GH can link and automatically close the issue after merge if the PR description contains Closes #<issue-number>, just so you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show a warning when at least one OIDC param detected, but not all are set
2 participants