Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not open menu on Esc key press #1866 #1891

Merged
merged 5 commits into from
Mar 17, 2023
Merged

Conversation

marek-mihok
Copy link
Contributor

Closes #1866

Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marek-mihok. Please add some accompanying unit tests as well.

@mturoci mturoci merged commit 2091ab4 into master Mar 17, 2023
@mturoci mturoci deleted the feat/issue-1866 branch March 17, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui.menu should not open when Esc key is pressed.
2 participants