Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Filter out empty strings for tags and filter options #1905 #1939

Merged
merged 5 commits into from
Apr 24, 2023
Merged

fix: Filter out empty strings for tags and filter options #1905 #1939

merged 5 commits into from
Apr 24, 2023

Conversation

marek-mihok
Copy link
Contributor

After fix:
image

Before fix:
image

Closes #1905

mturoci
mturoci requested changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marek-mihok. Please add unit tests as well.

ui/src/table.tsx Outdated Show resolved Hide resolved
mturoci
mturoci requested changes Apr 21, 2023
View reviewed changes
ui/src/table.test.tsx Outdated Show resolved Hide resolved
ui/src/table.test.tsx Outdated Show resolved Hide resolved
ui/src/table.test.tsx Outdated Show resolved Hide resolved
ui/src/table.test.tsx Outdated Show resolved Hide resolved
ui/src/table.test.tsx Outdated Show resolved Hide resolved
ui/src/table.test.tsx Outdated Show resolved Hide resolved
ui/src/table.test.tsx Outdated Show resolved Hide resolved
mturoci
mturoci approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marek-mihok!

@mturoci mturoci merged commit 48b5dc5 into master Apr 24, 2023
@mturoci mturoci deleted the feat/issue-1905 branch April 24, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mturoci mturoci mturoci approved these changes

@lo5 lo5 Awaiting requested review from lo5 lo5 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty space in table nor rendered properly for tags and also causing weird filter behavior
2 participants
@marek-mihok @mturoci