Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent components from being overlapped by the table sticky header #1996

Merged
merged 5 commits into from
May 31, 2023

Conversation

marek-mihok
Copy link
Contributor

@marek-mihok marek-mihok commented May 26, 2023

This PR fixes a dialog being overlapped by table group sticky header. However this change does not fix the overlap for the overlay card:

Screen.Recording.2023-05-30.at.18.05.28.mov

Closes #1980

@marek-mihok marek-mihok changed the title fix: Prevent components from being overlapped by the sticky header of ui.table fix: Prevent components from being overlapped by the table sticky header May 30, 2023
@marek-mihok marek-mihok marked this pull request as ready for review May 30, 2023 16:09
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marek-mihok. Is there any other alternative approach we could consider? Does side_panel need to be included in this PR as well?

ui/src/table.tsx Outdated Show resolved Hide resolved
ui/src/parts/styleConstants.ts Outdated Show resolved Hide resolved
@marek-mihok
Copy link
Contributor Author

marek-mihok commented May 31, 2023

@mturoci as agreed in a personal discussion, I'm hardcoding the z-index values for now and we need to think how to avoid z-indexes completely. I've created a separate issue for that.

Does side_panel need to be included in this PR as well?

Including ui.side_panel is not needed since it imports the styling of ui.dialog.

@mturoci mturoci merged commit 6b36b1c into master May 31, 2023
@mturoci mturoci deleted the feat/issue-1980 branch May 31, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Column headers brought to front
2 participants