Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow dynamic value change for range slider #1154 #2094

Merged
merged 5 commits into from
Aug 3, 2023

Conversation

marek-mihok
Copy link
Contributor

The PR fulfills these requirements: (check all the apply)

  • It's submitted to the main branch.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
  • When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
  • If changes were made to ui folder, unit tests (make test) still pass.
  • New/updated tests are included

This PR partially resolves issue #1154.

NOTE: Do not forget to update status in this comment once merged.

ui/src/range_slider.tsx Outdated Show resolved Hide resolved
ui/src/range_slider.tsx Outdated Show resolved Hide resolved
ui/src/range_slider.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mturoci mturoci force-pushed the fix/dynamic-value-change-range-slider branch from 3599c32 to 8ffc7f0 Compare August 3, 2023 10:10
@mturoci mturoci merged commit ade23c3 into main Aug 3, 2023
2 checks passed
@mturoci mturoci deleted the fix/dynamic-value-change-range-slider branch August 3, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants