fix: Dynamic choices change for single/multi-valued dialog dropdown #1154 #2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mturoci
requested changes
Aug 4, 2023
mturoci
approved these changes
Aug 7, 2023
mturoci
force-pushed
the
fix/dynamic-choice-change-dialog-dropdown
branch
from
f46dcde
to
ff2369f
Compare
marek-mihok
added a commit
that referenced
this pull request
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fulfills these requirements: (check all the apply)
mainbranch.feat: Add a button #xxx, where "xxx" is the issue number).Closes #xxx, where "xxx" is the issue number.uifolder, unit tests (make test) still pass.Currently the value/values prop can be updated dynamically through Wave app for base dropdown and for both single and multi-valued dialog dropdown. However the dynamic update of choices can be done only for the base dropdown. This PR unifies the behavior and brings support for dynamic update of choices also for multi-valued and single-valued dialog dropdown.
NOTE: Do not forget to update status in this comment once merged.