Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dynamic choices change for single/multi-valued dialog dropdown #1154 #2104

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

marek-mihok
Copy link
Contributor

The PR fulfills these requirements: (check all the apply)

  • It's submitted to the main branch.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
  • When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
  • If changes were made to ui folder, unit tests (make test) still pass.
  • New/updated tests are included

Currently the value/values prop can be updated dynamically through Wave app for base dropdown and for both single and multi-valued dialog dropdown. However the dynamic update of choices can be done only for the base dropdown. This PR unifies the behavior and brings support for dynamic update of choices also for multi-valued and single-valued dialog dropdown.

NOTE: Do not forget to update status in this comment once merged.

ui/src/dropdown.tsx Outdated Show resolved Hide resolved
ui/src/dropdown.test.tsx Show resolved Hide resolved
@mturoci mturoci force-pushed the fix/dynamic-choice-change-dialog-dropdown branch from f46dcde to ff2369f Compare August 7, 2023 08:04
@mturoci mturoci merged commit a105424 into main Aug 7, 2023
2 checks passed
@mturoci mturoci deleted the fix/dynamic-choice-change-dialog-dropdown branch August 7, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants