Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v1.1.0 pre-release QA based fixes #2276 #2277

Merged
merged 6 commits into from
Mar 5, 2024
Merged

Conversation

marek-mihok
Copy link
Contributor

@marek-mihok marek-mihok commented Mar 4, 2024

The PR fulfills these requirements: (check all the apply)

  • It's submitted to the main branch.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
  • When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
  • If changes were made to ui folder, unit tests (make test) still pass.
  • New/updated tests are included

This PR fixes several issues based on the v1.0.0 pre-release QA, namely:

  • Audio annotator: Wrong annotator dimensions if Wave app is loaded when browser tab is not visible
  • Audio annotator: In specific scenario user was able to activate empty tag and annotate with it
  • Toolbar: Download prop example was not working due to link being from different origin.

TBD:

Closes #2276

@marek-mihok marek-mihok marked this pull request as ready for review March 5, 2024 13:18
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mturoci mturoci merged commit 9323f8f into main Mar 5, 2024
2 checks passed
@mturoci mturoci deleted the feat/issue-2276 branch March 5, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-release QA before v1.1.0
2 participants