Update setup.py #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring xhtml2pdf to the current 0.0.6 version. It is compatible with the project and it solves issues when generating reports with large amount of rows that caused "Division by zero" errors caused by the CSS even though the css was valid. See for reference on the error: xhtml2pdf/xhtml2pdf#20 I have had to revisit my css as the structure of the generation is slightly different, but not much work required.
|
I will hold it a bit since it might introduce regression for existing reports, I might keep this one for the 1.2 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring xhtml2pdf to the current 0.0.6 version.
It is compatible with the project and it solves issues when generating reports with large amount of rows that caused "Division by zero" errors caused by the CSS even though the css was valid.
See for reference on the error:
xhtml2pdf/xhtml2pdf#20
I have had to revisit my css as the structure of the generation is slightly different, but not much work required.