Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to upload file from context menu #268

Merged
merged 1 commit into from
Mar 25, 2019

Conversation

wacki4
Copy link
Contributor

@wacki4 wacki4 commented Mar 23, 2019

Also done uploading multiple files from local to remote using context menu instead of drag&drop.

@cschindl
Copy link
Collaborator

Hi @wacki4,

the idea is great, but it would be nice if you could not only select files but also directories to upload them.

It would be best to create the function "upload" in ftp-remote-edit.js which only check here whether a file or a directory should be uploaded. Then I would call the appropriate already existing function (uploadFile, uploadDirectory).

@cschindl cschindl added this to the Next Release milestone Mar 24, 2019
@wacki4
Copy link
Contributor Author

wacki4 commented Mar 24, 2019

So... which first? Maybe You would like to help with one of them? Or You don't have time for it so i should make both on free time?

@cschindl
Copy link
Collaborator

I can finish your work (upload / download) because I have some free time at the moment. Download would be more complex than upload. So I would start with that.

@wacki4
Copy link
Contributor Author

wacki4 commented Mar 24, 2019

I now started download, upload looks for me more complex? Maybe teamwork, You would look at upload then, i will try download, if i stop somewhere or would need some help i will write to You on pull request.

For now directory is creating ;)

@cschindl
Copy link
Collaborator

@wacki4 I have opened a new branch "upload-from-context-menu". Here are my adjustments included. It should be finished so far. I said yes upload is a lot easier ;) But you may be able to get some of the structure for the download function here.

@wacki4
Copy link
Contributor Author

wacki4 commented Mar 25, 2019

So i think both completed... ;) Time to new release? I will try to make import.

@cschindl cschindl changed the base branch from master to development March 25, 2019 17:08
@cschindl cschindl merged commit c0b2f24 into h3imdall:development Mar 25, 2019
@cschindl
Copy link
Collaborator

I merged both pull requests into the developer branch. But I still need this refactor the whole file, so I can use the functions uploadFile/uploadDirectory and downloadFile and downloadDirectory in the other functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants