Build with swc instead of tsc #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Should be good now |
|
Just noticed I accidentally committing my yarn error log... 😅 |
ThatOneCalculator
changed the title
ThatOneCalculator
changed the title
ThatOneCalculator
changed the title
ThatOneCalculator
force-pushed
the
swc
branch
from
0f53a9b
to
6e11716
Compare
ThatOneCalculator
changed the title
|
In the first place, did you feel that the build was slow? And is there any reason why you choose swc over esbuild? |
|
Yeah, the build was pretty slow for hot reloading and testing. Esbuild is also fairly slow in comparison to swc. |
|
Anyway, please rebase this with the master branch. |
it feels like a lot of friendica servers are slow or unreliable...
|
@h3poteto rebased, and tests pass. It's hard to find a friendica server with good uptime 🥴 |
This was referenced Sep 26, 2023
|
It seems that the issue of migrating from CommonJS to ESModules should be resolved alongside this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swc build: 42.63ms
tsc build: 7150ms