Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@paul, your log function has some great ideas in it, I just formatted it... #1111

Closed
wants to merge 1 commit into from
Closed

Conversation

devinrhode2
Copy link
Contributor

...cause every developer ought to read it.

… it a little, cause every developer ought to read it.
@drublic
Copy link
Member

drublic commented Jun 1, 2012

Thank you for your contribution.
Currently there is a discussion in #1107 about removing the log-function, because it removes the original line-number where the logging was output.

If we decide to keep the function I'd love to see it "readable" (also the IIFE which makes it save to use log()).

@necolas
Copy link
Member

necolas commented Jun 1, 2012

Thanks. I've made this file readable in a branch I'm about to push for review, so this will be taken care of while we wait on updating the code itself.

@necolas necolas closed this Jun 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants